feat: requests/httpx e2e tests + refactor#19
Merged
sohankshirsagar merged 7 commits intomainfrom Jan 9, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 20 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/httpx/instrumentation.py">
<violation number="1" location="drift/instrumentation/httpx/instrumentation.py:171">
P1: REPLAY fallback to a real request bypasses drop transforms. If a transform rule is supposed to block an outbound call, a REPLAY miss will now still hit the network. Apply `should_drop_outbound_request(...)` (and raise `RequestDroppedByTransform`) before calling `original_request` in the REPLAY no-mock fallback path.</violation>
<violation number="2" location="drift/instrumentation/httpx/instrumentation.py:246">
P1: Async REPLAY fallback to a real request bypasses drop transforms (same regression as sync). Apply the drop check before `await original_request(...)` to avoid unexpected outbound calls in REPLAY mode.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/httpx/instrumentation.py">
<violation number="1" location="drift/instrumentation/httpx/instrumentation.py:115">
P2: Hardcoded "GET" method in default response doesn't match the actual request method. If a background request uses POST/PUT/DELETE, the response's request object will incorrectly show "GET". Consider accepting the method parameter to ensure consistency.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.