Skip to content

Conversation

@illwieckz
Copy link
Member

@illwieckz illwieckz commented Mar 8, 2025

Our submodules may provide symbols not provided by system libraries.

See on engine side:

@sweet235
Copy link
Contributor

sweet235 commented Mar 8, 2025

LGTM, did not test.

@illwieckz
Copy link
Member Author

illwieckz commented Mar 8, 2025

Hmmm, this uncovers more -fPIC madness.

@slipher
Copy link
Contributor

slipher commented Mar 10, 2025

Our submodules may provide symbols not provided by system libraries.

What do you mean by that? Like the OpenAL Soft library which may be built without symbols for the extension functions (and then won't link with Daemon)? If the system libraries don't actually work, the option to use them must be removed entirely.

We might want to avoid building additional code on a platform that runs slowly such as Travis. It would be ideal to have some builds using the option with each of the possible values for better coverage as these options are worth testing. I didn't get around to reporting it but building Freetype as submodule doesn't work if you build both Daemon and Unvanquished.

@slipher
Copy link
Contributor

slipher commented Mar 10, 2025

OK, I discovered the motivation for the PR. #3330 uses a Lua 5.3 function while the APT install command requests Lua 5.2.

@illwieckz
Copy link
Member Author

It's better to test in CI the build we do in releases anyway.

@illwieckz illwieckz force-pushed the illwieckz/ci-submodules/sync branch from 678c756 to 37bb6d0 Compare March 17, 2025 16:15
@illwieckz illwieckz force-pushed the illwieckz/ci-submodules/sync branch 2 times, most recently from 8d05b7a to 5438eac Compare March 24, 2025 15:36
@illwieckz illwieckz force-pushed the illwieckz/ci-submodules/sync branch from 5438eac to f9df24b Compare March 24, 2025 16:28
@illwieckz illwieckz marked this pull request as draft March 24, 2025 16:29
@illwieckz illwieckz changed the title ci: use submodules for freetype and lua WIP: ci: use submodules for freetype and lua Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants