Skip to content

Add bounds_t with pre-aligned mins and maxs #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add bounds_t with pre-aligned mins and maxs #3265

wants to merge 1 commit into from

Conversation

@illwieckz
Copy link
Member

@illwieckz illwieckz commented Dec 30, 2024

@illwieckz illwieckz marked this pull request as draft December 30, 2024 19:25
@illwieckz illwieckz force-pushed the illwieckz/bounds/sync branch from 308947f to b0ab583 Compare December 30, 2024 23:08
@illwieckz
Copy link
Member Author

illwieckz commented Dec 30, 2024

Hmmm, it looks like we need explicit padding:

src\engine/qcommon/q_shared.h(302): error C2220: the following warning is treated as an error
src\engine/qcommon/q_shared.h(302): warning C4324: 'bounds_t': structure was padded due to alignment specifier
src\engine/qcommon/q_shared.h(1721): warning C4324: 'cplane_t': structure was padded due to alignment specifier

@illwieckz illwieckz mentioned this pull request Dec 31, 2024
Draft
@illwieckz illwieckz force-pushed the illwieckz/bounds/sync branch from b0ab583 to 2df7200 Compare December 31, 2024 02:23
@illwieckz illwieckz force-pushed the illwieckz/bounds/sync branch 3 times, most recently from 791184a to 709c30e Compare January 30, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illwieckz