Finish up Redsky's circle menu refactor #3048
Conversation
A shallow Object Oriented abstraction of circle menus. Concrete implementation derive from CircleMenu prototype. They must handle data acquisition, displaying info and option selection. In turn, objects inherit from prototype all mechanisms for building menu and all major event handlers. All these mechanisms centralised in CircleMenu object's methods, but can be easily overwritten to handle exceptional behaviour.
This is kinda wonky because right click does not register when you're hovering over a button...
|
I guess this is the one running on the Lab server? When opening the menus they appear for a short moment upside down. The mouse seems to wobble to much when moving to the selected items. I think that could be removed. |
|
I think the Lab server has other changes. It makes the icons change size on hover, which this PR doesn't do. |
|
I added the scale changes. This has lead to a bug I need to investigate. |
|
Ah i was already wondering how it was done cause i didn't see anything in the PR. Looking at the code it seems fine. The planned parts from the original PR ( #2904 ) would be nice additions but they can also be added later. |
|
Gentle bump |
|
A slightly modified version of this is live on the Bug Squash server. Feel free to try it out. The only difference is that on the bug squash server, the icons scale. |
|
Hmm, this felt into limbo. It would be cool to have this merged. |
|
I vaguely recall that there might have been some bugs... Since I'm working on input stuff, I added a quick fix to get the closing on right click: #3425. I almost cherry-picked the first commit here to get closing on left click outside the buttons too. But I realized that's not so great without the sectors implementation, since then the menu can close if you missed the button on accident. |
It was already in a pretty good state, but I fixed conflicts and also added right click to close.