fix: remove false success log & improve retry log#111
Merged
ds-filipknefel merged 4 commits intomainfrom Jun 10, 2024
Merged
Conversation
awalker4
approved these changes
Jun 10, 2024
christinestraub
added a commit
to Unstructured-IO/unstructured-js-client
that referenced
this pull request
Jun 14, 2024
This PR is a clone of Unstructured-IO/unstructured-python-client#111 ### Summary - remove false success log in split-page after error hook - moves success/failure logs to the LoggerHook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR introducing more logging two things turned out lacking:
This PR removes the faulty success log, moves success/failure logs to the
LoggerHookand introduces logging forConnectionErrorretries.