Skip to content

chore/enable publishing for python client 🎉 #102

Merged
awalker4 merged 3 commits intomainfrom
austin/publish-client
Jun 4, 2024
Merged

chore/enable publishing for python client 🎉 #102
awalker4 merged 3 commits intomainfrom
austin/publish-client

Conversation

@awalker4
Copy link
Copy Markdown
Collaborator

@awalker4 awalker4 commented Jun 3, 2024

Changes:

  • Bring the publish step back to the speakeasy workflow, regenerate the github action with speakeasy configure publishing
  • Remove incorrect readme note about parent_id being disabled
  • Knock the package version back down to 0.23.0 for continuity with PyPI versions

Changes:
* Bring the publish step back to the speakeasy workflow, regenerate the github action with
`speakeasy configure publishing`
* Remove incorrect readme note about parent_id being disabled
* Knock the package version back down to 0.23.0 for continuity with PyPI versions
@awalker4 awalker4 requested a review from Coniferish June 3, 2024 18:35
@awalker4 awalker4 changed the title chore/enable publishing for python client chore/enable publishing for python client 🎉 Jun 3, 2024
@awalker4 awalker4 requested review from badGarnet June 3, 2024 18:46
@Coniferish
Copy link
Copy Markdown
Contributor

Has the client been regenerated since the PR that changed the element types to a list of dicts? When testing on this branch I'm getting element objects that don't have any metadata (regardless of whether the pdf is being split by the client)

@awalker4
Copy link
Copy Markdown
Collaborator Author

awalker4 commented Jun 3, 2024

Oof, great catch. The new openapi.json hasn't been deployed yet. We'll have to have this pr sit behind that, plus I'll add a unit test to check the output format.

@awalker4
Copy link
Copy Markdown
Collaborator Author

awalker4 commented Jun 4, 2024

Okay, response schema fixed in #103. However, putting this on pause to figure out some page splitting issues.

@awalker4 awalker4 enabled auto-merge (squash) June 4, 2024 03:05
@awalker4 awalker4 disabled auto-merge June 4, 2024 15:31
@awalker4 awalker4 closed this Jun 4, 2024
@awalker4 awalker4 reopened this Jun 4, 2024
@awalker4 awalker4 enabled auto-merge (squash) June 4, 2024 23:04
@awalker4 awalker4 merged commit 0f61907 into main Jun 4, 2024
@awalker4 awalker4 deleted the austin/publish-client branch June 4, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants