Open
Conversation
rbiseck3
changed the title
Comment on lines
+10
to
+11
| output = generate_yaml(app="test.assets.typed_dict_response:sample_function") | ||
| file_path = results_path / "simple.yaml" |
There was a problem hiding this comment.
Nitpick: there is no obvious relation between sample_function stored in test.assets.typed_dict_response.py, and expected_results/simple.yaml . Naming it like expected_results/typed_dict_response:sample_function.yaml would make it painfully clear, unfortunately it's a mouthful. Maybe it's ok, or maybe just using the filename, or a function name, would be good enough. I'll leave it for you to decide, to not keep this PR waiting any longer.
hubert-rutkowski85
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initial introduction of new
etl-schemathat takes the same pointers to a python function asetl-uvicornand prints the generated schema as yaml to populate in a manifest for a given plugin. This can be updated to support writing output to a yaml file.Example:
pip install . PYTHONPATH=. etl-schema test.assets.typed_dict_response:sample_function inputs: properties: content: properties: name: type: string value: type: number required: - name - value type: object required: - content type: object outputs: properties: response: type: object required: - response type: object