Conversation
Member
|
LGTM, did you try it? Integration tests are failing because those can't be allowed from another repo. I'll need to fork your branch and redo it from the repo so all the tests are executed properly. Let me know when you think it's good so i do just that! Thanks for the PR |
Contributor
Author
|
Sorry for multiple commits :V |
Member
|
No worries! I don't mind. |
Contributor
Author
I tried running build and tests locally and all checks passed. Tests on PR checks failed because I added 'engines' property on package.json that force Node20. GH runner installed Node18 by default, so it was failing because of that. |
Vadorequest
requested changes
Feb 5, 2024
Member
|
I wrote that comment 5d ago and forgot to send it 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
yarn installstepsCloses #57