added suppourt for Irish#24
Merged
Merged
Conversation
Collaborator
|
lgtm (verified in-person, however, awaiting verification from another translator) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Irish. There is some translation trickery so I am double checking several of my choices and will update soon.
Had to use a fair amount of underscores but attempted to find one-word options when possible.
Some considerations:
Irish is Verb Subject Object. There are two words for "is". I went with the copula (is) because of the expected use case. There are multiple words/phrases for "for".
For "continue" I chose the word for "skip" thinking it might be clearer that it is passing over that iteration and going to the next one.
Also tricky for:
"má" : "if" (figured not dá)
"seachas_sin" : "else" (wanted to say otherwise/in any other case)
and wanted to copy the "elif" combined thing. Suggested "sinnó" : "elif"
for -> ag_gach ? (figured "le" or "do" wouldn't be flexible enough)
in -> i, sa, san? (I need to pick one and "i" might mess up some syntax. We might be able to change the grammar so they can use any of the three for "in")
return -> give? tabhair
Thought about "agus" for "while" but then obviously "and" wouldn't work so. Might need to edit this choice later.
Picked aon for "any", and Faic for "None" as it was one word as opposed to "ar bith" or confusing it with "Aon".
Checking all of this with Ellen Corbett.