Fixes for pooling Unity UI, and automatic pool creation.#4
Open
brettmjohnson wants to merge 4 commits intoUnityPatterns:masterfrom
Open
Fixes for pooling Unity UI, and automatic pool creation.#4brettmjohnson wants to merge 4 commits intoUnityPatterns:masterfrom
brettmjohnson wants to merge 4 commits intoUnityPatterns:masterfrom
Conversation
… isn't required for initial setup. And the fallback to normal instantiation is no longer needed and has been removed. Added a warning for when Recycle gets called but no pool is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for pooling Unity UI, related to SetParent and RectTransforms.
Also now automatically creates a pool if none found when Spawn() is called. So now Spawn/Recycle a one-to-one with Instantiate/Destroy.