Gradient2 gradient#496
Closed
hugoymh wants to merge 5 commits intoUnity-UI-Extensions:developmentfrom
Closed
Conversation
Modify Mesh should respond to gradient key updates in inspector and runtime
Contributor
|
Thanks for the PR, with Unity now confirming ongoing support for Unity UI, we will get right on this. |
…to support Unity UI
Contributor
|
I think you need to rebase from Development (not release) as it is now showing any changes at the moment. Might actually be easy since the U6 update, to just start a fresh PR against development @hugoymh And thank you for continuing the journey with the UI Extensions. It was a huge sigh of relief when Unity announced they were continuing to support Unity UI |
Author
|
no problem |
Author
|
Turns out the fix has already been merged along with PR #493. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unity UI Extensions - Pull Request
Overview
Follow-up suggestion to PR #466
Changes
Gradient2 would only reflect changes to EffectGradient keys only at initialization (e.g. entering Play Mode)
Suggested amendment should reflect changes both in Inspector and in Runtime.