Skip to content

fix: remove OnClientConnectedCallback registration from StatsDisplay #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 3 commits into from
Jun 4, 2021
Merged

fix: remove OnClientConnectedCallback registration from StatsDisplay #882

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ea6f2
style
NoelStephensUnity Jun 4, 2021
82acc6f
fix
NoelStephensUnity Jun 4, 2021
b88dd20
Merge branch 'develop' into fix/StatsDisplayOnClinetConnectedCallback
NoelStephensUnity Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion testproject/Assets/Tests/Manual/Scripts/StatsDisplay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public class StatsDisplay : NetworkBehaviour
private Text m_ClientServerToggleText;
private List<ulong> m_ClientsToUpdate = new List<ulong>();


private bool m_IsServer;

private void Start()
Expand Down Expand Up @@ -72,6 +71,14 @@ private void OnClientConnectedCallback(ulong clientId)
}
}

/// <summary>
/// Remove our OnClientConnectedCallback registration when we are destroyed
/// </summary>
private void OnDestroy()
{
NetworkManager.OnClientConnectedCallback -= OnClientConnectedCallback;
}

/// <summary>
/// Used by UI Button click event
/// </summary>
Expand Down