[BACKPORT] chore: Optimize NetworkBehaviour.NetworkManager property#3720
Merged
michalChrobot merged 1 commit intorelease/2.6.0from Oct 15, 2025
Merged
[BACKPORT] chore: Optimize NetworkBehaviour.NetworkManager property#3720michalChrobot merged 1 commit intorelease/2.6.0from
michalChrobot merged 1 commit intorelease/2.6.0from
Conversation
* chore: Optimize NetworkBehaviour.NetworkManager property * ensure internal state is completely reset on behaviour despawn * Fix tests * Ensure NetworkManagerOwner is always correctly set * Update tests to explicitly set NetworkManagerOwner * Fix InstantiateAndSpawn * fixes * Hide error for now * Put error back and fix timetravel * try things * Fix onStartSweep * put back changed test code * Remove unneeded changes * Simplify changes * Put back needed change * Set NetworkManager in InstantiateAnd Spawn * Check for IsSpawned on despawn * Add recreating test * Clean up test helpers some * Fix the DistributedAuthorityCodecTests --------- Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
michalChrobot
changed the title
NoelStephensUnity
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of a PR with fixes for issues discovered during 2.6.0 release playtest
Jira ticket
N/A
Changelog
N/A @NoelStephensUnity you can confirm
Documentation
N/A
Testing & QA (How your changes can be verified during release Playtest)
Will be part of next playtest
Backports
This is a backport of #3700