fix: ChangeOwnership sending own clientId and added NetworkSceneHandle struct#3647
Merged
NoelStephensUnity merged 36 commits intodevelop-2.0.0from Oct 10, 2025
Merged
Conversation
EmandM
changed the title
…ere are no valid receivers
| { | ||
| "name": "Unity", | ||
| "expression": "6000.4.0a3", | ||
| "define": "SCENE_MANAGEMENT_SCENE_HANDLE_NO_INT_CONVERSION" |
Member
There was a problem hiding this comment.
Out of curiosity, why 6000.4? Similar question to define above, why 6000.3
Member
Author
There was a problem hiding this comment.
Entities broke us 🥲 in 6.3 they introduced a struct instead of an int for the scene handle. and then in 6.4 they removed the implicit conversions between the struct and the int.
michalChrobot
approved these changes
Oct 9, 2025
EmandM
changed the title
EmandM
added a commit
that referenced
this pull request
Oct 10, 2025
NoelStephensUnity
approved these changes
Oct 10, 2025
Member
There was a problem hiding this comment.
Great job narrowing down the core issue with the more recent SceneHandle updates in v6.3 with a nice wrapper class, NetworkSceneHandle, to provide a smooth experience for users!
🥇
In the name of "getting the PR queue uncongested", the changelog entry for this can be found in #3707 to avoid running through CI just for the entry update.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
ClientIdslistNetworkSceneHandlestruct to wraps theSceneManagement.Scene.handlerepresentation.intto aSceneHandlestruct.intand theSceneHandleNetworkSceneHandlestruct allows us to hide this change from the rest of the codebase. It may also enable us to refactor our scene management as it gives us a more powerful representation of a scene.Jira ticket
MTTB-1570
MTTB-1646
Changelog
NetworkSceneHandlestruct that wraps theSceneManagement.Scene.handlerepresentation. This allows us to work smoothly with the latest functionality of scene management in the UnityEngineDocumentation
Testing & QA (How your changes can be verified during release Playtest)
We need to playtest with the SceneLoading scene to ensure that's still all working as expected.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This test is specific to 2.x so no backport required.