fix: [UpPort] Replaced HashSet.UnionWith() with loop to avoid heap alloc#3573
Merged
NoelStephensUnity merged 4 commits intodevelop-2.0.0from Aug 5, 2025
Merged
fix: [UpPort] Replaced HashSet.UnionWith() with loop to avoid heap alloc#3573NoelStephensUnity merged 4 commits intodevelop-2.0.0from
NoelStephensUnity merged 4 commits intodevelop-2.0.0from
Conversation
EmandM
changed the title
just minor style fix
NoelStephensUnity
approved these changes
Aug 5, 2025
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Just made a minor change.
The rest looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while profiling a server that had frequent pending dirty network objects to process
Changelog
Fixed: Removed heap alloc in NetworkBehaviourUpdate
Testing and Documentation
Backport
This is an up-port of #3568