fix: Active scene not being added to server side NetworkSceneManager scenes loaded [MTT-7537] #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue with integration testing where: - the scene handler registration was being registered multiple times - the server registration was not passing in true to NetcodeIntegrationTestHelper.RegisterHandlers - the IntegrationTestSceneHandler.CoroutineRunner could get destroyed if the active scene it was instantiated within was unloaded (now it is migrated to the DDOL) - Registration of the currently active scene during the scene handler registration was adjusted to no longer use NetworkSceneManager.GetAndAddNewlyLoadedSceneByName (but still registers the scene).
ShadauxCat
approved these changes
Oct 4, 2023
NoelStephensUnity
deleted the
fix/add-active-scene-to-server-side-scenes-loaded
branch
NoelStephensUnity
added a commit
that referenced
this pull request
Oct 5, 2023
…scenes loaded [MTT-7537] (#2723) * fix This fixes the issue where the currently active scene, on the server side, is not taken into consideration as being a valid "loaded scene" which can cause issues as outlined in GitHub issue #2722. * fix: TestHelpers This resolves an issue with integration testing where: - the scene handler registration was being registered multiple times - the server registration was not passing in true to NetcodeIntegrationTestHelper.RegisterHandlers - the IntegrationTestSceneHandler.CoroutineRunner could get destroyed if the active scene it was instantiated within was unloaded (now it is migrated to the DDOL) - Registration of the currently active scene during the scene handler registration was adjusted to no longer use NetworkSceneManager.GetAndAddNewlyLoadedSceneByName (but still registers the scene). * test Added an integration test: `NetworkSceneManagerFixValidationTests.InitialActiveSceneUnload` This validates the fix for #2722. * update Adding change log entry for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where the server side NetworkSceneManager instance was not adding the currently active scene to its list of scenes loaded which would result in a permanently scene event in progress state if you:
Any attempt to load or unload a scene after this point would fail.
MTT-7537
fix: #2722
Changelog
NetworkSceneManagerinstance was not adding the currently active scene to its list of scenes loaded.Testing and Documentation
NetworkSceneManagerFixValidationTests.InitialActiveSceneUnload