feat: Log errors when Relay/WebSocket settings are mismatched #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-lemay-unity
requested review from
TylerUnity and
chrispope
as code owners
ShadauxCat
approved these changes
Oct 2, 2023
chrispope
approved these changes
Oct 4, 2023
NoelStephensUnity
added a commit
that referenced
this pull request
Oct 5, 2023
Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error logs when the transport's "Use WebSockets" checkbox mismatches the Relay server data. Without this error, it's very hard to figure out what is wrong just by observing what's happening. The ability to check if some Relay server data is using WebSockets is new in UTP 2.1, so I had to add a define for that.
Changelog
N/A
Testing and Documentation