feat(NetworkManager): expose methods for clientId to transportId mappings#2668
Closed
patrickexe wants to merge 1 commit intoUnity-Technologies:developfrom
Closed
Conversation
|
Yeah, I hit this too, this is a must. Considering even UnityTransport uses this in its Send method, it is obvious these needs to be public as other transports (and users) definitely might use this. |
Contributor
Author
Yeah I'm currently running on a forked version of this repo, with this change implemented. It's slightly out of sync with main but feel free to use or just fork your own copy if you need this feature soon 👍🏼 |
Member
|
This PR is continued in #3515 |
EmandM
added a commit
that referenced
this pull request
Jun 24, 2025
[MTTB-950](https://jira.unity3d.com/browse/MTTB-950) implements: #2668 fixes: #2359 ## Changelog - Added: Mappings for ClientId to TransportId ## Testing and Documentation - Includes unit tests. ## Backport Backported in #3515 --------- Co-authored-by: Patrick Coglan <coglanpatrick@icloud.com>
EmandM
added a commit
that referenced
this pull request
Jun 24, 2025
…3515) [MTTB-950](https://jira.unity3d.com/browse/MTTB-950) implements: #2668 fixes: #2359 ## Changelog - Added: Mappings for ClientId to TransportId ## Testing and Documentation - Includes unit tests. ## Backport Backport of #3516 --------- Co-authored-by: Patrick Coglan <coglanpatrick@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature gives access to 2 new get methods in NetworkManager that allow the user to convert between
clientIdandtransportIdand vice versa.Our use case for this feature was using Facepunch.Steamworks and our own twist on the community transport that pairs with it. We need to be able to get the
SteamIdof any connected client from theirclientIdfor various reasons, one being server-side saving of client specific data that is then identified viaSteamId.This feature resolves #2359.
Changelog
clientIdtotransportIdand vice versa.Testing and Documentation