fix(unet-channels): Invoking .Clear() on two Dictionaries within the Shutdown-function#199
Merged
TwoTenPvP merged 2 commits intoUnity-Technologies:masterfrom Apr 4, 2019
BabakSamimi:hotfix
Merged
fix(unet-channels): Invoking .Clear() on two Dictionaries within the Shutdown-function#199TwoTenPvP merged 2 commits intoUnity-Technologies:masterfrom BabakSamimi:hotfix
TwoTenPvP merged 2 commits intoUnity-Technologies:masterfrom
BabakSamimi:hotfix
Conversation
added 2 commits
April 4, 2019 06:46
…Shutdown-function GetConfig() will try to insert new kvp-pairs even though they already exists. Clearing them fixes this and allow, for example, doing StartHost() -> StopHost() -> StartHost() within the same session.
Contributor
|
🎉 This PR is included in version 8.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
MrCool92
pushed a commit
to MrCool92/MLAPI
that referenced
this pull request
Dec 6, 2020
…Shutdown-function (Unity-Technologies#199) * fix(unet-channels): Invoking .Clear() on two Dictionaries within the Shutdown-function GetConfig() will try to insert new kvp-pairs even though they already exists. Clearing them fixes this and allow, for example, doing StartHost() -> StopHost() -> StartHost() within the same session. * changed the fields back to read-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetConfig() will try to insert already existing kvp-pairs. Clearing the dictionaries fixes this and allows, for example, doing StartHost() -> StopHost() -> StartHost() within the same session.