chore: Increment package versions for NGO 1.0.0-pre.4 and update changelogs#1563
Merged
0xFA11 merged 3 commits intorelease/1.0.0from Jan 6, 2022
Merged
Conversation
ashwinimurt
force-pushed
the
backport/update-package-versions-pre.4
branch
from
00ceafc to
25d775e
Compare
ashwinimurt
changed the title
ashwinimurt
force-pushed
the
backport/update-package-versions-pre.4
branch
from
5a535c2 to
c959aab
Compare
| - Updated Netcode for GameObjects dependency to 1.0.0-pre.4 [#1562](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1562) | ||
| - Removed 'Maximum Packet Size' configuration field in the inspector. This would cause confusion since the maximum packet size is in effect always the MTU (1400 bytes on most platforms). [#1403](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1403) | ||
| - Updated com.unity.transport to 1.0.0-pre.10 [#1501](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1501) | ||
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
Contributor
There was a problem hiding this comment.
Should remove this line. It was part of an earlier iteration of that PR and is not correct anymore. I guess I forgot to remove it from the changelog when I backported the changes to release/1.0.0.
0xFA11
reviewed
Jan 5, 2022
| - Updated Netcode for GameObjects dependency to 1.0.0-pre.4 [#1562](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1562) | ||
| - Removed 'Maximum Packet Size' configuration field in the inspector. This would cause confusion since the maximum packet size is in effect always the MTU (1400 bytes on most platforms). [#1403](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1403) | ||
| - Updated com.unity.transport to 1.0.0-pre.10 [#1501](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1501) | ||
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
Contributor
There was a problem hiding this comment.
Suggested change
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
ashwinimurt
force-pushed
the
backport/update-package-versions-pre.4
branch
from
c959aab to
61956de
Compare
ashwinimurt
force-pushed
the
backport/update-package-versions-pre.4
branch
from
61956de to
0ca9728
Compare
0xFA11
reviewed
Jan 6, 2022
| ### Added | ||
|
|
||
| - Added new 'Max Send Queue Size' configuration field in the inspector. This controls the size of the send queue that is used to accumulate small sends together and also acts as an overflow queue when there are too many in-flight packets or when other internal queues are full. | ||
| - Added new 'Max Send Queue Size' configuration field in the inspector. This controls the size of the send queue that is used to accumulate small sends together and also acts as an overflow queue when there are too many in-flight packets or when other internal queues are full. (#1491) |
Contributor
There was a problem hiding this comment.
I'm sorry to bother you again @simon-lemay-unity :)
This line should stay, right?
Contributor
There was a problem hiding this comment.
Yes, this one is correct.
simon-lemay-unity
approved these changes
Jan 6, 2022
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #1562
Changelog
com.unity.netcode.gameobjects