chore: Increment package versions for NGO 1.0.0-pre.4 and update changelogs#1562
Merged
chore: Increment package versions for NGO 1.0.0-pre.4 and update changelogs#1562
Conversation
ashwinimurt
force-pushed
the
chore/update-package-versions-pre.4
branch
from
0f59078 to
99caead
Compare
ashwinimurt
changed the title
ashwinimurt
force-pushed
the
chore/update-package-versions-pre.4
branch
3 times, most recently
from
05da90e to
8f7303b
Compare
| - Updated Netcode for GameObjects dependency to 1.0.0-pre.4 [#1562](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1562) | ||
| - Removed 'Maximum Packet Size' configuration field in the inspector. This would cause confusion since the maximum packet size is in effect always the MTU (1400 bytes on most platforms). [#1403](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1403) | ||
| - Updated com.unity.transport to 1.0.0-pre.10 [#1501](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1501) | ||
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
Contributor
There was a problem hiding this comment.
Should remove this line, it was added in an earlier iteration of that PR and then removed. I forgot to remove it in the backport of the PR for release/1.0.0 which I guess is how it got here.
Contributor
Author
There was a problem hiding this comment.
Correct, I added it here because this existed in the release branch but not on develop. I will remove.
0xFA11
reviewed
Jan 5, 2022
| - Updated Netcode for GameObjects dependency to 1.0.0-pre.4 [#1562](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1562) | ||
| - Removed 'Maximum Packet Size' configuration field in the inspector. This would cause confusion since the maximum packet size is in effect always the MTU (1400 bytes on most platforms). [#1403](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1403) | ||
| - Updated com.unity.transport to 1.0.0-pre.10 [#1501](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1501) | ||
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
Contributor
There was a problem hiding this comment.
Suggested change
| - The 'Send Queue Batch Size' configuration field now controls the size of the send queue, rather than the size of a single batch of messages. Consequently, it should be set much higher than it was previously. [#1491](https://github.com/Unity-Technologies/com.unity.netcode.gameobjects/pull/1491) |
so the suggestion here is to remove this line like this right @simon-lemay-unity ?
ashwinimurt
force-pushed
the
chore/update-package-versions-pre.4
branch
from
8f7303b to
3ef0872
Compare
ashwinimurt
force-pushed
the
chore/update-package-versions-pre.4
branch
from
3ef0872 to
263b67c
Compare
simon-lemay-unity
approved these changes
Jan 6, 2022
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
type:backport-release-*label. After you backport the PR, the label changes tostat:backported-release-*.CHANGELOG.mdfile.Changelog
com.unity.netcode.gameobjects