Feature/player persistence prefab refactor #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runtime lists & associated assets)
…yer type (boy & girl), sending character SO guids over network
fernando-cortez
added
the
1-Needs Review
fernando-cortez
changed the title
Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacter.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs
Outdated
Show resolved
Hide resolved
… fix, handling avatar guid through its own component
| [SerializeField] | ||
| AvatarRegistry m_AvatarRegistry; | ||
|
|
||
| void Awake() |
Contributor
There was a problem hiding this comment.
I would expect symmetry in this class
For awake and for register, I would expect a destroy and a unregister
… parity, hierarchy names cleanup
SamuelBellomo
approved these changes
Jul 9, 2021
Cosmin-B
approved these changes
Jul 14, 2021
Cosmin-B
added a commit
that referenced
this pull request
Sep 14, 2021
* feature/adding-UTP: Adding ParrelSync and updating third party notice.md (#357) updating to latest UTP Feature/player persistence prefab refactor (#349) upping MLAPI develop version (#355) Update to MLAPI: onnetworkspawn refactoring, player prefab removed from networkmanager prefab list (#352) porting to UTP # Conflicts: # Assets/BossRoom/Prefabs/NetworkingManager.prefab # Assets/BossRoom/Scenes/Startup.unity # Assets/BossRoom/Scripts/Client/BossRoom.Client.asmdef # Assets/BossRoom/Scripts/Shared/BossRoom.Shared.asmdef # Assets/BossRoom/Scripts/Shared/Game/UI/Editor/NetworkLatencyWarning.cs # Packages/manifest.json # Packages/packages-lock.json # ProjectSettings/PackageManagerSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part two of player persistence task. Jira here.
Breaking changes:
Changes:
PersistentPlayerprefab. This is now MLAPI's "Default Player Prefab". This contains two NetworkBehaviours (name and character type). Next PR will integrate these NetworkVariables into ServerCharSelect and ServerBossRoomState for spawning. These NetworkObjects represent each player connection and as the name suggests, persist across scenes.Playerprefab has been renamed toPlayerAvatar. This prefab is spawned with client ownership inside of BossRoom scene.PlayerGraphicsprefab has been refactored to serve as the parent prefab for all character graphics. Character graphics for all 8 character types are variants of this root, with their associated model.AvatarScriptableObject that now represents a player character. This contains a reference to the avatar'sCharacterClassSO, as well as its associated graphics prefabs.AvatarSO also serializes a GUID.AvatarRegistry) has been created to associate allAvatars to the game. As a dev, this is the starting point for adding a new Character to the game.NetworkGuidStatehas been introduced. The usage of this NetworkVariable<byte[]> can be seen insideCharacterContainer, where the received Avatar Guid is validated from theAvatarRegistry.