Skip to content

Conversation

@RikuTheFuffs
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs commented Mar 26, 2025

Description

  • Added in-Editor tutorials, and related required changes, for Anticipation scene in Multiplayer Use Cases sample.

Issue Number(s)

Contribution checklist

  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

How to test

  1. Clone this branch
  2. Open the Multiplayer use Cases sample (it's in the "Basic" folder) using Unity 6000.0.23f1
  3. Go to Tutorials > Show Tutorials
  4. In the tutorials Window, select the "Examples" category
  5. Check that the Client-side anticipation tutorial is there and that the copy is understandable

image

  1. Start the tutorial, check that you can complete all steps and that the copy is understandable
  2. Check that this Completion Dialog is displayed at the end of the tutorial

image

Notes

  1. The icon of the tutorial will be added later in a separate PR, once we validate the content of the tutorial
  2. The anticipation scene will be added to the "selection screen" of Multiplayer Use Cases as part of https://jira.unity3d.com/browse/MTT-11679

@RikuTheFuffs RikuTheFuffs marked this pull request as ready for review March 26, 2025 16:41
@RikuTheFuffs RikuTheFuffs requested a review from a team as a code owner March 26, 2025 16:41
@sentinel-u3d sentinel-u3d bot requested a review from Elfi0Kuhndorf March 26, 2025 16:52
@Elfi0Kuhndorf
Copy link
Contributor

image
One small feedback already. Would be nice to have a picture for the anticipation sample as well :D

@Elfi0Kuhndorf
Copy link
Contributor

image
small typo. Also out of curiosity, why player 4? To change things up?

@Elfi0Kuhndorf
Copy link
Contributor

image
extra space needed behind InputManager

@Elfi0Kuhndorf
Copy link
Contributor

Also is it possible to enable the Project browser for step 8, as it suggests to use it for opening the scripts?

@RikuTheFuffs
Copy link
Contributor Author

RikuTheFuffs commented Mar 26, 2025

Would be nice to have a picture for the anticipation sample as well :D

There's a note about that in the PR's notes :P

[typos]

(I'll address the typos, nice catches)

Also out of curiosity, why player 4? To change things up?

It's because we can't highlight Player 1 as the Multiplayer Play Mode window doesn't have a unique naming for each "Player" in the UI, and the visual element of the main editor has the same ID of the other ones.

The only options I have for visual element highlighting in tutorials are "First, All and Last".

This means that what I can highlight is:

  1. First -> Only the part that corresponds to the Main Editor Play (and we don't want this)

image

  1. All -> Every editor player, including the Main Editor Play (and we don't want this)

image

  1. Last -> Player 4

image

Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Everything within the tutorial works and the links of the final popup work as well.

@RikuTheFuffs RikuTheFuffs merged commit f536453 into develop Mar 27, 2025
30 checks passed
@RikuTheFuffs RikuTheFuffs deleted the feat/anticipation-tutorials branch March 27, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants