Skip to content

feat: adding IET table of contents, welcome page, 1st IET: setup UGS [MTT-8695] [MTT-8699] #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fernando-cortez merged 12 commits into from
Apr 7, 2025
Merged

feat: adding IET table of contents, welcome page, 1st IET: setup UGS [MTT-8695] [MTT-8699] #277

fernando-cortez merged 12 commits into from
Apr 7, 2025

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Mar 10, 2025 •
edited
Loading

Description

This PR adds an In-Editor Tutorial welcome page, as well as a welcome dialog.

Issue Number(s)

MTT-8695
MTT-8699

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • [ N/A ] Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

Base automatically changed from feat/dedicated-game-server-sample/upgrade-to-multiplayer-services-sdk to develop March 25, 2025 18:55
@fernando-cortez fernando-cortez marked this pull request as ready for review April 1, 2025 00:57
@fernando-cortez fernando-cortez requested a review from a team as a code owner April 1, 2025 00:57
@sentinel-u3d sentinel-u3d bot requested a review from RikuTheFuffs April 1, 2025 08:50
RikuTheFuffs
RikuTheFuffs requested changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the README is still here, and that its script is also missing (should be deleted as part of https://jira.unity3d.com/browse/MTT-8699 )
image

@RikuTheFuffs
Copy link
Contributor

RikuTheFuffs commented Apr 1, 2025

Apart from the two issues above, everything else works as expected. However it seems that this PR includes several commits unrelated to IET, which alter functionality of other parts of the project.

Were these meant to be pushed on a separate branch?
If so, I'd close this PR, branch from this commit , and make a new PR to merge that branch only, so we do not risk adding unwanted changes.

image

@fernando-cortez
Copy link
Contributor Author

fernando-cortez commented Apr 3, 2025

Apart from the two issues above, everything else works as expected. However it seems that this PR includes several commits unrelated to IET, which alter functionality of other parts of the project.

Were these meant to be pushed on a separate branch? If so, I'd close this PR, branch from this commit , and make a new PR to merge that branch only, so we do not risk adding unwanted changes.

image

That's from this PR pointing to a branch that was merged, so the old commits remain.
This will be squash-merged anyways too, so history-wise it'll still appear as just one commit from here to develop.
The only Files Modified are tutorial items too, so we're good there too.

@fernando-cortez fernando-cortez merged commit 3580104 into develop Apr 7, 2025
30 checks passed
@fernando-cortez fernando-cortez deleted the feat/dedicated-game-server-sample/iet-welcome-page branch April 7, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernando-cortez @RikuTheFuffs