fix the no fire sound problem#126
Closed
Alexander5421 wants to merge 1 commit intoUnity-Technologies:mainfrom
Closed
fix the no fire sound problem#126Alexander5421 wants to merge 1 commit intoUnity-Technologies:mainfrom
Alexander5421 wants to merge 1 commit intoUnity-Technologies:mainfrom
Conversation
|
|
fernando-cortez
suggested changes
Sep 21, 2023
Contributor
fernando-cortez
left a comment
fernando-cortez
left a comment
There was a problem hiding this comment.
Looks good besides the changes I've mentioned!
| @@ -1,4 +1,5 @@ | |||
| using System; | |||
| using System.Runtime.CompilerServices; | |||
Contributor
There was a problem hiding this comment.
This directive can be removed!
| } | ||
| } | ||
|
|
||
Contributor
There was a problem hiding this comment.
This extra space should be removed!
Contributor
|
Hi @Alexander5421, this PR looks good. However, if your branch could base its work off of our develop branch, that would be greatly appreciated. Having the fire sound be played on the invocation of a ClientRpc is a good fix! |
Contributor
Author
|
Hi @fernando-cortez, I created a new pull request #138 and merged it into develop instead of the main |
Contributor
|
@Alexander5421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to solve #125