Skip to content

Updated approximations #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saloed merged 4 commits into from
Jul 28, 2025
Merged

Updated approximations #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a615d3c
[fix] fixed approximations
MchKosticyn May 19, 2024
939ecab
[chore] updated jacodb version
MchKosticyn Jul 25, 2025
2b5b5df
[fix] fixed `String` approximation
MchKosticyn Jul 27, 2025
58b0694
[todo] added todo's
MchKosticyn Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions approximations/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repositories {
}

private val jacodbPackage = "com.github.UnitTestBot.jacodb"
private val jacodbVersion = "453ec7c0b3" // jacodb neo branch
private val jacodbVersion = "d7dd9d343b" // jacodb neo branch

dependencies {
compileOnly("$jacodbPackage:jacodb-api-jvm:$jacodbVersion")
Expand Down Expand Up @@ -43,4 +43,3 @@ publishing {
}
}
}

15 changes: 12 additions & 3 deletions approximations/src/main/java/generated/java/lang/StringImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class StringImpl implements Serializable {
@java.io.Serial
private static final long serialVersionUID = -6849794470754667710L;

private static final int STRING_LENGTH_MAX = 256;
private static final int STRING_LENGTH_MAX = 50;

static final byte UTF16 = 1;

Expand Down Expand Up @@ -219,8 +219,7 @@ private void _assumeInvariants(StringImpl obj) {
Engine.assume(obj.value != null);
int len = obj.value.length >> obj.coder;
Engine.assume(len >= 0);
// TODO: add Engine.assumeSymbolic(instance, bool) #ASAP
Engine.assume(len <= STRING_LENGTH_MAX);
Engine.assumeSymbolic(obj, len <= STRING_LENGTH_MAX);
}

private void _assumeInvariants() {
Expand Down Expand Up @@ -293,6 +292,10 @@ public void getBytes(int srcBegin, int srcEnd, byte[] dst, int dstBegin) {
}

public static boolean latin1Equals(byte[] value, byte[] other) {
Boolean arrayEquals = Engine.arrayEquals(value, other);
if (arrayEquals != null)
return arrayEquals;

if (value.length == other.length) {
for(int i = 0; i < value.length; ++i) {
if (value[i] != other[i]) {
Expand All @@ -313,11 +316,17 @@ public boolean equals(Object anObject) {
} else {
if (anObject instanceof StringImpl) {
StringImpl aString = (StringImpl)anObject;
Engine.assume(aString.value != value);
_assumeInvariants(aString);
return (!COMPACT_STRINGS || this.coder == aString.coder) && latin1Equals(this.value, aString.value);
}

return false;
}
}

public boolean isEmpty() {
_assumeInvariants();
return value.length == 0;
}
}
Loading