Conversation
Damtev
added
ctg-documentation
Damtev
force-pushed
the
damtev/static_initializers_analysis_design_doc
branch
from
f520487 to
c1d6d1d
Compare
CaelmBleidd
reviewed
Sep 20, 2022
Member
CaelmBleidd
left a comment
CaelmBleidd
left a comment
There was a problem hiding this comment.
Seems good, but I suggest asking @olganaumenko for help with English
docs/StaticInitializersAnalysis.md
Outdated
Comment on lines
+1
to
+4
| # Symbolic analysis of static initializers | ||
|
|
||
| ## Current behavior | ||
| ### Problem |
Member
There was a problem hiding this comment.
I think it is a bad idea to leave three consecutive titles without text between them
docs/StaticInitializersAnalysis.md
Outdated
| setStaticField(optionalClazz, "EMPTY", empty); | ||
| ``` | ||
|
|
||
| Such behavior is mostly strange for a user and should be properly fixed - we should not set such static fields with initializers manually. |
Member
There was a problem hiding this comment.
What does such mean? What criteria make these fields such?
CaelmBleidd
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See the corresponding document.
Type of Change