Actualise test for using except on provider with fallback#2660
Merged
IlyaMuravjov merged 1 commit intomainfrom Oct 16, 2023
Merged
Actualise test for using except on provider with fallback#2660IlyaMuravjov merged 1 commit intomainfrom
IlyaMuravjov merged 1 commit intomainfrom
Conversation
Markoutte
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2659 by updating tests, that were verifying outdated semantic of
except.Previously
provider.except(filter)wasn't recursive and was removing all the fallbacks.Semantic of
exceptwas updated to solve the issues with using.except { it is ObjectValueProvider }on the following provider causingAbstractsObjectValueProviderandBuilderObjectValueProviderto be remoed (since they are fallbacks) andObjectValueProvideritself not to be removed (since it's not on the top level, i.e. it's a part ofValueProvider.Combinedthat is nested intoValueProvider.Fallbackthat is nested into anotherValueProvider.Combined).How to test
Automated tests
Self-check list