Remove builtins modules from sys.path#1574
Merged
tamarinvs19 merged 3 commits intomainfrom Dec 22, 2022
Merged
Conversation
denis-fokin
reviewed
Dec 22, 2022
|
|
||
| return Pair( | ||
| sources.map { it.path }.toSet(), | ||
| sources.map { it.path.replace("\\", "\\\\") }.toSet(), |
Collaborator
There was a problem hiding this comment.
Please extract such things as a utility function. And consider situations when we are already have two back slashes in the path.
denis-fokin
reviewed
Dec 22, 2022
| if (sources.any { source -> | ||
| val sourcePath = source.canonicalPath | ||
| if (source.isDirectory && sourcePath != null) { | ||
| directory.virtualFile.canonicalPath?.startsWith(sourcePath) ?: false |
Collaborator
There was a problem hiding this comment.
Consider improving the code
denis-fokin
approved these changes
Dec 22, 2022
denis-fokin
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 7402d71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now we add in sys.path only subpaths of project path. Also temporary files don't start with numbers now, this modification can help with problems on Windows when some path has structure
...\123_run_....Fixes # (issue)
Type of Change
How Has This Been Tested?
Manual Scenario
import collections:collectionsChecklist (remove irrelevant options):