Skip to content

Change configure.ac to linux-friendly defaults#14

Open
lava wants to merge 1 commit intoUnNetHack:masterfrom
lava:autoconf
Open

Change configure.ac to linux-friendly defaults#14
lava wants to merge 1 commit intoUnNetHack:masterfrom
lava:autoconf

Conversation

@lava
Copy link

@lava lava commented Aug 22, 2015

Hi, I recently tried building unnethack on ubuntu 15.04. There were a few issues which this pull request fixes:

  • Use of ? as wildcard in Makefile (changed to make builtin wildcard command)
  • Binary is not able to read .unnethackrc config file from encrypted home directory, due to setuid to user games. I've changed it back to use setgid instead.

Feel free to reject this pull request if it breaks the windows build (I don't have a windows machine to test), or if there was a good reason for using setuid by default that I didn't see.

@lava lava force-pushed the autoconf branch 3 times, most recently from 1d5835f to 563f258 Compare August 22, 2015 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant