Fix: Boundary labels now visible when setting lonlim/latlim #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
A bunch of tests will fail on geo, but they look visually ok in my opinion. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
beckermr
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #428
Fixed issue where the outermost gridline labels would be hidden when setting
lonlimorlatlimon geographic axes. The problem had two causes: (1) cartopy's gridlinerxlim/ylimwere not properly synchronized with the view intervals - onlyylimwas set and to an incorrect value, and (2) the extent was being shifted rather than expanded, causing the leftmost boundary to exclude gridlines at exactly the limit value. The fix ensures bothxlimandylimare set to the actual view intervals with appropriate expansion, and that extent bounds are expanded symmetrically. Added comprehensive unit tests to verify boundary labels are created and visible for positive/negative longitudes and various latitude ranges.