Hotfix: bar labels cause limit to reset for unaffected axis. #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvanelteren
changed the title
cvanelteren
force-pushed
the
hotfix-bar-labels-reset
branch
from
2867e89 to
7bc099d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Hmm had a look at this for a while and I am not really understanding how the xlimits are set. For |
cvanelteren
force-pushed
the
hotfix-bar-labels-reset
branch
from
2f38a92 to
46c2f29
Compare
Collaborator
Author
|
The difference on the plot is minor some shifting but everything else looks ok. |
beckermr
reviewed
Nov 16, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
I don't understand the pr given the description. The other axis is still reset. Can you update the description for me so I can understand better why is going on?
Collaborator
Author
|
Done |
beckermr
approved these changes
Nov 16, 2025
Collaborator
Author
|
Great. I will draft a release and bump the number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #412
This PR addresses an issue where limits are reset when adding bar labels in a loop (see #412). The issue occurs because the
bar_labelsexpects that the bar are in a container which will set the range on all the bars. This PR fixes this by consideringdataLimdirectly rather than theBarContainer.