Hotfix: unsharing causes excessive draw in jupyter #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvanelteren
force-pushed
the
hotfix-unshare
branch
from
63a3b9e to
bd05d22
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cvanelteren
force-pushed
the
hotfix-unshare
branch
from
60f5f25 to
d26cc7c
Compare
beckermr
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407
Remove the deepcopy on the formatters to prevent triggering redraw but ensuring that the formatters are different objects.
Note: I removed the lines now all together as the test were failing, and apparently the lines were not necessary anyway (i.e. they are already in dependent).