Skip to content

fix: clarify read-only DNS lookup and show nameservers - #2020

Open
superdav42 wants to merge 2 commits into
mainfrom
fix/dns-lookup-info-nameservers
Open

fix: clarify read-only DNS lookup and show nameservers#2020
superdav42 wants to merge 2 commits into
mainfrom
fix/dns-lookup-info-nameservers

Conversation

@superdav42

@superdav42 superdav42 commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Present read-only DNS lookup as normal information rather than a missing-provider warning.
  • Show a nameserver summary from the existing NS lookup records to help administrators identify their DNS host, without guessing a provider or adding DNS requests.
  • Normalize and deduplicate nameservers; hide the entire nameserver section when none are found, without an empty-state notice.
  • Leave provider-managed DNS editing unchanged.

Implementation

  • views/domain/admin-dns-management.php: use the existing neutral information styling, retain the secondary configuration link, and display escaped, wrapping nameserver text only after a successful lookup.
  • assets/js/dns-table.js: derive the sorted summary from existing entries and auth records.
  • DESIGN.md: record the informational status and responsive behaviour.

Verification

  • PHPCS and PHPStan passed for the updated template.
  • ESLint passed for the updated script; all pre-commit checks passed.
  • vendor/bin/phpunit --filter Domain_Edit_Admin_Page_Test: 67 tests, 112 assertions passed.
  • Desktop and mobile browser preview checked nameserver normalization/deduplication, empty/loading/error states, text escaping, and long-hostname wrapping. No browser errors were reported.
  • Follow-up browser verification confirmed the section is hidden for empty results and A-only results, remains visible for NS records, and the removed notice is absent. PHPCS, PHPStan, and pre-commit checks passed again.

Browser verification used the actual WordPress-rendered worktree template and script mounted in an isolated browser on the local domain page. The shared site runs another worktree, so this was a browser-only preview, not deployed end-to-end verification. No customer site or shared plugin configuration was changed.

Generated minified assets are intentionally excluded per repository policy and must be regenerated by the release build.

aidevops.sh v3.39.49 plugin for OpenCode

@superdav42 superdav42 added the origin:interactive Created by interactive user session label Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f58b6ea8-3b1f-4a98-91aa-9c647b94c144
Commits

Reviewing files that changed from the base of the PR and between fc19799 and 653e8b4.

Files selected for processing: 2
  • DESIGN.md
  • views/domain/admin-dns-management.php

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b8b4df37-0660-4016-b850-963a3e007f14
Commits

Reviewing files that changed from the base of the PR and between 58da122 and fc19799.

Files selected for processing: 3
  • DESIGN.md
  • assets/js/dns-table.js
  • views/domain/admin-dns-management.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The DNS lookup view now derives and displays returned nameservers. The no-provider notice uses neutral informational styling and states that lookup results are read-only. Design guidance documents the nameserver summary and existing layout behavior.

Changes: DNS lookup display

Layer / File(s) Summary
Nameserver summary and unconfigured state
assets/js/dns-table.js, views/domain/admin-dns-management.php, DESIGN.md		 The DNS table derives unique, sorted nameservers from NS records. The view displays them when results are available and no error exists, or shows a message when none are returned. The no-provider notice describes the lookup as read-only, and the design guidance documents these states.

Priority: Pending latest changes

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to fc197

The changed DNS lookup display is consistent with the existing response contract and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: clarifying read-only DNS lookup behavior and displaying nameservers.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42
superdav42 marked this pull request as ready for review October 25, 2026 15:25
@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

origin:interactive Created by interactive user session

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@superdav42