feat(cli): add deploy happy path#47
Merged
Merged
Conversation
robertandreimoldoveanu
force-pushed
the
feat/cli_deploy
branch
2 times, most recently
from
7ea8dc8 to
0ea819f
Compare
anbalase
approved these changes
Feb 21, 2025
robertandreimoldoveanu
force-pushed
the
feat/cli_deploy
branch
from
0ea819f to
745ee5e
Compare
cristipufu
reviewed
Feb 22, 2025
| "--tenant-feed", "-tf", "personal_feed", type=bool, flag_value=False, default=True | ||
| ) | ||
| @click.option("--personal-feed", "-pf", "personal_feed", type=bool, flag_value=True) | ||
| def deploy(root, version_increase, personal_feed): |
Member
There was a problem hiding this comment.
- I think we should keep it simple for now, no paramaters, don't overengineer the CLI. We need a reference system to built the foundation:
uipath.json- source of truth for entrypoints/input-output/bindingpyproject.toml- source of truth for all the package metadata (author, name, description, version) - if you want to change these, you need to change the source of truth, you don't need 100 params in the cli
-
The current flow uses tenant published packages, switching to PW is another story for another time
-
uipath deployshould actually calluipath pack&uipath publishand cleanup at the end (these commands can be overridden in extensions, eg you want to use the overridden pack command for deploying w/o overriding deploy as well - composable pattern). here's an example: https://github.com/UiPath/uipath-python/blob/main/sdk/core/uipath_sdk/_cli/cli_new.py#L69
This creates a better foundation that can be extended later when specific needs arise, rather than trying to anticipate all possible parameters upfront.
robertandreimoldoveanu
force-pushed
the
feat/cli_deploy
branch
from
745ee5e to
69cad3b
Compare
robertandreimoldoveanu
force-pushed
the
feat/cli_deploy
branch
from
69cad3b to
a099922
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also added cli flag to pack & deploy commands to specify a semver increase