-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add custom guardrails service and guardrails models [AL-197] #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| model_config = ConfigDict(populate_by_name=True, extra="allow") | ||
|
|
||
|
|
||
| ValidatorParameter = Annotated[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValidatorParameter, EnumListParameterValue, MapEnumParameterValue, NumberParameterValue should stay in uipath-python. They are related to Out of the Box guardrails.
| model_config = ConfigDict(populate_by_name=True, extra="allow") | ||
|
|
||
|
|
||
| class BuiltInValidatorGuardrail(BaseGuardrail): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also remain in uipath-python?
| ) | ||
|
|
||
|
|
||
| class CustomGuardrailsService(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's find a better name for this, eg: GuardrailValidator, GuardrailEvaluator etc - also get rid of "custom" from models and everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristipufu We need a differentiator to distinguish between Custom|Deterministic guardrails and BuiltInValidator guardrails. If Custom sounds bad, what about DeterministicGuardrails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristipufu we still need this : guardrail_type: Literal["custom"] = Field(alias="custom") for agent.json deserialization. All other references where renamed to DeterministicGuardrails
396a1a3 to
6a8cfb7
Compare
6a8cfb7 to
de5d7f8
Compare
No description provided.