fix(ui5-calendar): set timestamp of daypicker on mousedown#13527
Open
hinzzx wants to merge 1 commit into
Open
Conversation
Collaborator
|
🚀 Deployed on https://pr-13527--ui5-webcomponents-preview.netlify.app |
GDamyanov
requested changes
May 15, 2026
Contributor
GDamyanov
left a comment
GDamyanov
left a comment
There was a problem hiding this comment.
Could we also add test?
| } | ||
|
|
||
| this._safelySetTimestamp(this._getTimestampFromDom(target)); | ||
| } |
Contributor
There was a problem hiding this comment.
Duplicated logic in _selectDate. this._safelySetTimeStamp is called also in onClick handler and cause one additional re render. So we can add additional variable in _selectDate like setTimestamp = true and call the method in onclick handler with value false since the timestamp is already set in on mouse down handler
Contributor
Screen.Recording.2026-05-15.at.10.59.46.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Clicking a day in
ui5-calendar/ui5-date-pickercould move focus to the wrong day.The root cause
_safelySetTimestamp(which determines the focused date) was only called during theclickevent, butonAfterRenderingfires afocus()call triggered by the precedingmousedown, beforeclick- so focus landed on the previously focused day instead of the clicked one.What We Did
mousedownWhat This Fixes
onAfterRenderingfiresfocus()before theclickevent resolvesFixes: #12914