fix adding swc configuration file support as an option#2143
fix adding swc configuration file support as an option#2143hanseltime wants to merge 1 commit intoTypeStrong:mainfrom
Conversation
|
hi @hanseltime . excited to see you try to get this into To be fair, I see the same failure on main branch. Is this what you are seeing as well or are you referring to a different sort of error? |
|
Hey @sdotson, If you are capable of running the various tests, etc. Then that might help. The contributing.md doc seems to be out of date (or just doesn't handle me running this on a linux machine pop-os). A list of the problems I have when trying to use the prescribed calls:
As an example^ Running tests fails due to the same typescript build failures and it seems testing types aren't recognized. I could try getting something to work, but since I'm not sure if that would affect tests, I'm personally hamstrung to verify it. For anyone who may be able to verify this, please feel free to do so! |
|
It sounds like something is going on with your local As I noted in my previous message, it looks like tests still pass on my local machine! If you'd like to add an additional test, I can run and verify for you if needed. |
|
@sdotson - Something is definitely going on. The yarn version is dictated by corepack from the project and I have verified that they match. Likewise with node. I have tried both 18 and 20 (18 is specified at places in the package.json). I may try getting to this to run on a different machine. Since I am not finding any additional direction in the Contributing.md though, I'm not very willing to spend a lot of time debugging the build/test system without someone who understands the system providing any gotchas (i.e. maybe they've always used X setting to bypass this problem). |
Summary
This PR implements what looks like the correct changes for ts-node to support specifying an swcConfig.
Unfortunately, the version of yarn has a bug that won't download the github based packages due to checksum mismatch and the tests seem very reliant on that particular yarn. If someone can point me to documentation for how to run the tests with out debugging tons of failures, I would be more than happy to implement additional tests.
This would unlock a lot of swc based flows as indicated in: #1856