Fix SWC support with stage 3 decorators#2136
Open
MuTsunTsai wants to merge 2 commits intoTypeStrong:mainfrom
Open
Fix SWC support with stage 3 decorators#2136MuTsunTsai wants to merge 2 commits intoTypeStrong:mainfrom
MuTsunTsai wants to merge 2 commits intoTypeStrong:mainfrom
Conversation
TechQuery
suggested changes
Apr 4, 2025
| decoratorMetadata: emitDecoratorMetadata, | ||
| legacyDecorator: true, | ||
| legacyDecorator: experimentalDecorators, | ||
| decoratorVersion: experimentalDecorators ? '2021-12' : '2022-03', |
There was a problem hiding this comment.
Suggested change
| decoratorVersion: experimentalDecorators ? '2021-12' : '2022-03', | |
| decoratorVersion: experimentalDecorators ? '2021-12' : '2023-11', |
Author
There was a problem hiding this comment.
Where did you get that 2023-11 from? SWC doesn't have that option: https://swc.rs/docs/configuration/compilation#jsctransformdecoratorversion
There was a problem hiding this comment.
Where did you get that 2023-11 from? SWC doesn't have that option: https://swc.rs/docs/configuration/compilation#jsctransformdecoratorversion
I saw this value in SWC error message & Babel document, maybe it hasn't been implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since TypeScript 5.0, stage 3 decorators had become the default while
experimentalDecoratorshad become the legacy standard. However, with SWC enabled, ts-node doesn't work correctly with stage 3 decorators. This PR fixes the config pass to SWC to make it things work as it should.Note: This part of the SWC config has been there since v1.3.47, so there's no need the change the dependency specifications.