Use WASM version of Lua instead of fengari for testing #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests failed due to incorrect iteration order And unexpected JS/Lua differences
Perryvw
reviewed
Mar 4, 2021
test/util.ts
Outdated
| /* eslint-disable jest/no-standalone-expect */ | ||
| import * as nativeAssert from "assert"; | ||
| import { lauxlib, lua, lualib, to_jsstring, to_luastring } from "fengari"; | ||
| import { lauxlib, lua, lualib } from "lua-wasm-bindings/dist/lua.54"; |
Member
There was a problem hiding this comment.
As we discussed on discord, please use 5.3 for tests as long as we do not officially support 5.4 yet. (I'd also be fine with another PR that adds 5.4 as supported LuaTarget)
Perryvw
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM bindings are in a separate repo and published to NPM.
https://github.com/TypeScriptToLua/lua-wasm-bindings
https://www.npmjs.com/package/lua-wasm-bindings
Multi version testing will be done in a different PR.