fixed declarations that reference their own identifiers#910
Merged
tomblind merged 4 commits intoTypeScriptToLua:masterfrom Aug 1, 2020
Merged
fixed declarations that reference their own identifiers#910tomblind merged 4 commits intoTypeScriptToLua:masterfrom
tomblind merged 4 commits intoTypeScriptToLua:masterfrom
Conversation
ark120202
reviewed
Jul 31, 2020
Co-authored-by: ark120202 <ark120202@gmail.com>
ark120202
reviewed
Jul 31, 2020
Perryvw
approved these changes
Jul 31, 2020
|
|
||
| const referenceLists = castArray(identifiers).map(i => i.symbolId && scopeSymbols.get(i.symbolId)); | ||
|
|
||
| return referenceLists.some(symbolRefs => symbolRefs && symbolRefs.length > 1); |
Member
There was a problem hiding this comment.
Maybe
Suggested change
| return referenceLists.some(symbolRefs => symbolRefs && symbolRefs.length > 1); | |
| return referenceLists.some(symbolRefs => symbolRefs?.length > 1); |
Collaborator
Author
There was a problem hiding this comment.
This change won't work as symbolRefs?.length resolves to number | undefined which can't be compared to a number like that. I could change it to something like (symbolRefs?.length || 0) > 1, but I feel like it looses clarity that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #894