Fix incorrectly escaped string.replace replace value#892
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Jun 10, 2020
Merged
Fix incorrectly escaped string.replace replace value#892Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
string.replace replace value#892Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Conversation
Perryvw
reviewed
Jun 1, 2020
test/unit/builtins/string.spec.ts
Outdated
| { inp: "hello test", searchValue: "test", replaceValue: "" }, | ||
| { inp: "hello test", searchValue: "test", replaceValue: "world" }, | ||
| { inp: "hello test", searchValue: "test", replaceValue: "%world" }, | ||
| { inp: "hello test", searchValue: " test", replaceValue: "." }, |
Member
There was a problem hiding this comment.
Could you also add some tests containing some of these other non-alphanumerics (both as search and replace values)?
| { inp: "hello %test", searchValue: "%test", replaceValue: "world" }, | ||
| { inp: "hello test", searchValue: "test", replaceValue: (): string => "a" }, | ||
| { inp: "hello test", searchValue: "test", replaceValue: (): string => "%a" }, | ||
| { inp: "aaa", searchValue: "a", replaceValue: "b" }, |
Member
There was a problem hiding this comment.
Why did you remove this? I don't think there is another test that replaces multiple references in the same string.
Perryvw
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865.