Skip to content

Get benchmark data to visualizer #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 14 commits into from
Oct 21, 2020
Merged

Get benchmark data to visualizer #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
26225b3
Try zlibbing output data
Perryvw May 18, 2020
939db41
Try with lz-string
Perryvw May 18, 2020
a67355f
Explicitly install lz-string
Perryvw May 18, 2020
2e37e45
Another try with regular zlib
Perryvw May 18, 2020
fa6dac6
Use deflateSync now
Perryvw May 18, 2020
4b5a395
Try without extra dependencies
Perryvw May 18, 2020
1ea416e
Once more, with dollarsign
Perryvw May 18, 2020
0c21451
Output raw results instead of processed table
Perryvw May 18, 2020
0e197cf
Fix run script
Perryvw May 18, 2020
17eb0d3
reverted package-lock
Perryvw Jun 10, 2020
b59f758
Add link to visualizer to benchmark result
Perryvw Jun 10, 2020
60c9c2a
Merge branch 'master' into benchmark-data-to-visualizer
Perryvw Jun 10, 2020
f88f149
prettier fix
Perryvw Jun 10, 2020
e780d49
Removed forgotten comment from benchmarking CI
Perryvw Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ jobs:
node-version: 12.13.1
# NPM
- name: NPM master
# TODO Lua types is only added manually to test the benchmark PR this can be removed again once the PR is merged
run: npm ci && npm run build && npm install -D lua-types
run: npm ci && npm run build
working-directory: master
- name: NPM commit
run: npm ci && npm run build
Expand Down Expand Up @@ -112,7 +111,12 @@ jobs:
const benchmarkInfoLua = JSON.parse(core.getInput('benchmark-info-lua', { required: true }));
const benchmarkInfoJIT = JSON.parse(core.getInput('benchmark-info-jit', { required: true }));

const summary = `### Lua5.3\n${benchmarkInfoLua.summary}\n### LuaJIT\n${benchmarkInfoJIT.summary}`;
const zlib = require('zlib');
const buffer = Buffer.from(core.getInput('benchmark-info-lua', { required: true }));
const compressed = zlib.deflateSync(buffer);

const summary = `[Open visualizer](https://typescripttolua.github.io/benchviz?d=${compressed.toString('base64')})\n`
+ `### Lua5.3\n${benchmarkInfoLua.summary}\n### LuaJIT\n${benchmarkInfoJIT.summary}`;

const text = `### Lua5.3\n${benchmarkInfoLua.text}\n### LuaJIT\n${benchmarkInfoJIT.text}`;

Expand Down
11 changes: 5 additions & 6 deletions benchmark/src/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,8 @@ function benchmark(): void {
oldBenchmarkResults = json.decode(oldBenchmarkData) as BenchmarkResult[];
}

// Compare results
const comparisonInfo = compareBenchmarks(oldBenchmarkResults, newBenchmarkResults);

// Output comparison info
outputBenchmarkData(comparisonInfo, newBenchmarkResults);
outputBenchmarkData(oldBenchmarkResults, newBenchmarkResults);
}
benchmark();

Expand All @@ -44,12 +41,14 @@ function compareBenchmarks(oldResults: BenchmarkResult[], newResults: BenchmarkR
return { summary: memoryComparisonInfo.summary, text: memoryComparisonInfo.text };
}

function outputBenchmarkData(comparisonInfo: { summary: string; text: string }, newResults: BenchmarkResult[]): void {
function outputBenchmarkData(oldResults: BenchmarkResult[], newResults: BenchmarkResult[]): void {
if (!arg[2]) {
// Output to stdout as json by default, this is used by the CI to retrieve the info
print(json.encode(comparisonInfo));
print(json.encode({ old: oldResults, new: newResults }));
} else {
// Output to file as markdown if arg[2] is set, this is useful for local development
// Compare results
const comparisonInfo = compareBenchmarks(oldResults, newResults);
const markdownDataFile = io.open(arg[2], "w+")[0]!;
markdownDataFile.write(comparisonInfo.summary + comparisonInfo.text);
}
Expand Down