Merged
Conversation
ark120202
reviewed
May 18, 2020
package.json
Outdated
| "ts-jest": "^25.2.1", | ||
| "ts-node": "^8.6.2" | ||
| "ts-node": "^8.6.2", | ||
| "zlib": "^1.0.5" |
Contributor
There was a problem hiding this comment.
zlib is a builtin module, it doesn't need a dependency
lolleko
reviewed
Jun 11, 2020
.github/workflows/ci.yml
Outdated
| @@ -62,7 +62,7 @@ jobs: | |||
| # NPM | |||
| - name: NPM master | |||
| # TODO Lua types is only added manually to test the benchmark PR this can be removed again once the PR is merged | |||
lolleko
added a commit
to lolleko/TypeScriptToLua
that referenced
this pull request
Nov 5, 2020
Benchmarks now hopefully work for pull requests from a fork Fixed comparison info not beeing emmitted correctly after TypeScriptToLua#878 Bump actions/github-script from 0.9.0 to v3 Moved create benchmark check script to standalone js file
Perryvw
pushed a commit
that referenced
this pull request
Nov 23, 2020
* Fixed various benchmark issues Benchmarks now hopefully work for pull requests from a fork Fixed comparison info not beeing emmitted correctly after #878 Bump actions/github-script from 0.9.0 to v3 Moved create benchmark check script to standalone js file * Formatting & Adjusted script path * Pass core to the js file * Output markdown directly to CLI instead of creating an actions check * Fixed github-script usage * Fixed visualizer data passing * Linting :) * Return benchmark info from github-script * Fixed glow flags * Update name of final step * Update .github/workflows/ci.yml Co-authored-by: ark120202 <ark120202@gmail.com> Co-authored-by: ark120202 <ark120202@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.