Fix side effects in string index causing issues#868
Merged
Conversation
ark120202
approved these changes
May 10, 2020
Comment on lines
40
to
41
| const table = context.transformExpression(expression.expression); | ||
| return lua.createTableIndexExpression(table, transformElementAccessArgument(context, expression), expression); |
Contributor
There was a problem hiding this comment.
That table variable name might be a bit confusing, since you don't necessarily access a property on a table. And in general the variable in this case doesn't seem to be very helpful here
Suggested change
| const table = context.transformExpression(expression.expression); | |
| return lua.createTableIndexExpression(table, transformElementAccessArgument(context, expression), expression); | |
| return lua.createTableIndexExpression( | |
| context.transformExpression(expression.expression), | |
| transformElementAccessArgument(context, expression), | |
| expression | |
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #867