Conversation
Run benchmarks on master and commit Run benchmarks on master and commit
ark120202
reviewed
May 7, 2020
Fixed popen behaviour Improved error handling Fixed tslint issues
Reverted lua-types dev version back to jit
Perryvw
reviewed
May 7, 2020
ark120202
reviewed
May 8, 2020
Perryvw
approved these changes
May 8, 2020
…nto memory-benchmark
Changed error handling to use throw instead of monads Added eslint and fixed linting issues
ark120202
reviewed
May 10, 2020
ark120202
approved these changes
May 10, 2020
Perryvw
reviewed
May 11, 2020
benchmark/README.md
Outdated
|
|
||
| **Running locally** | ||
|
|
||
| 1. Create a benchmark baseline called "benchmark_baseilne.json": |
Member
There was a problem hiding this comment.
Suggested change
| 1. Create a benchmark baseline called "benchmark_baseilne.json": | |
| 1. Create a benchmark baseline called "benchmark_baseline.json": |
Member
There was a problem hiding this comment.
Actually there are a lot of these copy pasted here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a preview of the results see: https://github.com/TypeScriptToLua/TypeScriptToLua/runs/653550386
From benchmark/README.md:
TSTL Benchmarks
These benchmarks are written in typescript and transpiled to lua by using tstl.
Currently only memory benchmarks are supported
To add a new benchmark add a new file to
memory_benchmarksand default export a function with the following type:
() => void.For example (memory_benchmarks/my_benchmark.ts):
Goal
The goal of memory benchmarks is to track how much (memory)
"garbage"is created by tstl.For that reason garabage collection is disabled in the benchmarks.
You can force the creation of
"garbage"by creating a lot of anonymous functions or temporary tables (see lua-users.org for more information).To avoid crashes in the CI your benchmark should not use more than 500MB of memory.
Running locally
tstl -p tsconfig.53.json && cd dist && lua -- run.lua benchmark_baseilne.jsontstl -p tsconfig.53.json && cd dist && lua -- run.lua benchmark_updated.json benchmark_baseilne.jsonIf you provide a path as third argument the comparison data will be written to that path instead.
tstl -p tsconfig.53.json && cd dist && lua -- run.lua benchmark_updated.json benchmark_baseilne.json result.md