Skip to content

Fixed class getters bug #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 2 commits into from
Apr 9, 2020
Merged

Fixed class getters bug #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04d40ef
Fixes class getters inheritance bug
Apr 9, 2020
a874fe5
Merge pull request #1 from TypeScriptToLua/master
Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lualib/Descriptors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function ____descriptorNewindex(this: any, key: string, value: any): void {

// It's also used directly in class transform to add descriptors to the prototype
function __TS__SetDescriptor(this: void, metatable: Metatable, prop: string, descriptor: PropertyDescriptor): void {
if (!metatable._descriptors) metatable._descriptors = {};
if (!rawget(metatable, "_descriptors")) metatable._descriptors = {};
metatable._descriptors[prop] = descriptor;

if (descriptor.get) metatable.__index = ____descriptorIndex;
Expand Down
20 changes: 20 additions & 0 deletions test/unit/classes/accessors.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,26 @@ test("get accessor override accessor", () => {
`.expectToMatchJsResult();
});

test("get accessor override accessor (multiple)", () => {
util.testFunction`
class Foo {
_foo = "foo";
get foo() { return this._foo; }
}
class Bar extends Foo {
_bar = "bar";
get foo() { return this._bar; }
}
class Baz extends Foo {
_baz = "baz";
get foo() { return this._baz; }
}
const bar = new Bar();
const baz = new Baz();
return bar.foo + baz.foo;
`.expectToMatchJsResult();
});

test("get accessor from interface", () => {
util.testFunction`
class Foo {
Expand Down