Conversation
Perryvw
left a comment
Perryvw
left a comment
There was a problem hiding this comment.
Not sure about this forced destructuring, and can we force consistent string characters (ie " instead of ')?
|
|
||
| if (classTbl[Symbol.hasInstance] !== undefined) { | ||
| // eslint-disable-next-line no-implicit-coercion | ||
| return !!classTbl[Symbol.hasInstance](obj); |
There was a problem hiding this comment.
wouldnt it be nicer to just change this to an actual comparison
There was a problem hiding this comment.
A comparison with true? I'm fine with doing that for now, but in the future (when we'll implement boolean coercion algorithm) I think it should use Boolean(...), since TypeScript doesn't check implementations of well-known symbols.
| // Variables NOT declared in for loop - catch iterator values in temps and assign | ||
| // for ____value0 in ${iterable} do | ||
| // ${initializer} = ____value0 | ||
| // eslint-disable-next-line no-lonely-if |
There was a problem hiding this comment.
This rule seems a little awkward. I think this is very much a case-by-case basis and would prefer not to have a few eslint-disables as possible.
There was a problem hiding this comment.
I guess that's true, though I don't think I had any issues with it in years of being in my config. I have disabled this rule and also fixed this case, since it actually turned out to look neater with the logic flow here
2 participants
No description provided.