Skip to content

handle non-indexable types for lefthand value of instanceof #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Perryvw merged 2 commits into from
Mar 13, 2020
Merged

handle non-indexable types for lefthand value of instanceof #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb2757
handle non-indexable types for lefthand value of instanceof
chrisbajorin Mar 13, 2020
b65f1fa
cleanup
chrisbajorin Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lualib/InstanceOf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function __TS__InstanceOf(this: void, obj: LuaClassInstance, classTbl: LuaClass)
return !!classTbl[Symbol.hasInstance](obj);
}

if (obj !== undefined) {
if (typeof obj === "object") {
let luaClass = obj.constructor;
while (luaClass !== undefined) {
if (luaClass === classTbl) {
Expand Down
22 changes: 22 additions & 0 deletions test/unit/classes/instanceof.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,28 @@ test("null instanceof Class", () => {
`.expectToMatchJsResult();
});

test("function instanceof Class", () => {
util.testFunction`
class myClass {}
const noop = () => {};
return (noop as any) instanceof myClass;
`.expectToMatchJsResult();
});

test("boolean instanceof Class", () => {
util.testFunction`
class myClass {}
return (false as any) instanceof myClass;
`.expectToMatchJsResult();
});

test("number instanceof Class", () => {
util.testFunction`
class myClass {}
return (5 as any) instanceof myClass;
`.expectToMatchJsResult();
});

test("instanceof export", () => {
util.testModule`
export class myClass {}
Expand Down