Assume files with imports to be modules#776
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Dec 26, 2019
Merged
Conversation
lolleko
reviewed
Dec 19, 2019
| public readonly options: CompilerOptions = this.program.getCompilerOptions(); | ||
| public readonly luaTarget = this.options.luaTarget ?? LuaTarget.LuaJIT; | ||
| public readonly isModule = isFileModule(this.sourceFile); | ||
| public readonly isModule = ts.isExternalModule(this.sourceFile); |
Member
There was a problem hiding this comment.
What if all imports are elided is a file still considered a module in that case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564.
Now it matches TypeScript's logic, making files with
importsorexportsmodules. It still keeps files without any imports or exports global, so probably shouldn't break too much things, because TypeScript already issued an unused variable diagnostic in these cases.